JGonzalez/fpakc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Rework of injection of particles with a special focus in 2DCyl to ensure an homogeneous distribution. #51

Merged
JorgeGonz merged 22 commits from issue/injection2DCyl into development 2024-07-11 18:51:43 +02:00
Conversation 3 Commits 22 Files changed 17 +220 -142
JorgeGonz commented 2024-07-11 18:46:16 +02:00 (Migrated from gitlab.com)
Copy link

It was a lot of work, but I finally solved it. I have checked that now the injection of particles gives the right distribution. I have added the possibility to determine the number of particles that are injected per cell to improve statistics. This required changes to the random functions but also to the 2DCyl node volume calculations.

Additional changes:

  • Fix in probes for an error I discovered while doing simulations to the IEPC 2024. Basically, they were not working because there was no summation process.
  • General revision of the code to reduce the number of warnings and remove unused variables.
  • It is possible to declare a "particles per cell" when loading variables from a background to improve statistics near the axis.
  • Change how the injection of A m^-2 works, and now it is multiplied by the area of the injection. This should work in all geometries.
It was a lot of work, but I finally solved it. I have checked that now the injection of particles gives the right distribution. I have added the possibility to determine the number of particles that are injected per cell to improve statistics. This required changes to the random functions but also to the 2DCyl node volume calculations. Additional changes: - Fix in probes for an error I discovered while doing simulations to the IEPC 2024. Basically, they were not working because there was no summation process. - General revision of the code to reduce the number of warnings and remove unused variables. - It is possible to declare a "particles per cell" when loading variables from a background to improve statistics near the axis. - Change how the injection of A m^-2 works, and now it is multiplied by the area of the injection. This should work in all geometries.
JorgeGonz commented 2024-07-11 18:46:16 +02:00 (Migrated from gitlab.com)
Copy link

assigned to @JorgeGonz

assigned to @JorgeGonz
JorgeGonz commented 2024-07-11 18:46:31 +02:00 (Migrated from gitlab.com)
Copy link

marked this merge request as ready

marked this merge request as **ready**
JorgeGonz commented 2024-07-11 18:51:43 +02:00 (Migrated from gitlab.com)
Copy link

mentioned in commit 065bb1d13e

mentioned in commit 065bb1d13e11aeacbbd162f63e5dc8a9dff77588
JorgeGonz (Migrated from gitlab.com) merged commit 065bb1d13e into development 2024-07-11 18:51:43 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: JGonzalez/fpakc#51
No description provided.
Delete branch "issue/injection2DCyl"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?